fix: DH-22758: Fix column resize bug on columns with the same display text#2691
Open
vbabich wants to merge 4 commits into
Open
fix: DH-22758: Fix column resize bug on columns with the same display text#2691vbabich wants to merge 4 commits into
vbabich wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
==========================================
+ Coverage 50.47% 50.48% +0.01%
==========================================
Files 787 787
Lines 44836 44841 +5
Branches 11609 11610 +1
==========================================
+ Hits 22629 22639 +10
- Misses 22161 22183 +22
+ Partials 46 19 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
requested review from
a team,
dgodinez-dh and
mattrunyon
and removed request for
a team and
mattrunyon
Comment on lines
485
to
487
| // Always show separator for the last column | ||
| if (nextColumnIndex == null) { | ||
| return true; |
Comment on lines
+1262
to
+1267
| shouldDrawSeparator = GridUtils.hasColumnSeparatorAtDepth( | ||
| model, | ||
| depth, | ||
| columnIndex, | ||
| nextColumnIndex | ||
| ); |
dgodinez-dh
approved these changes
May 29, 2026
dgodinez-dh
left a comment
dgodinez-dh
left a comment
Contributor
There was a problem hiding this comment.
Code changes look good to me. Copilot brought up two issues. One of them looks to be a comment on pre-existing code. The other, I'm not sure if it is relevant to the intendend change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.