Skip to content

Conversation

@Artmann
Copy link

@Artmann Artmann commented Dec 2, 2025

Summary by CodeRabbit

  • Chores
    • Node.js version requirement updated to 22.x across all packages and workflows.
    • Major version updates: server, sql-parser, and sqlint packages upgraded to 3.0.0.
    • Dependencies updated to compatible major versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

📝 Walkthrough

Walkthrough

This pull request standardizes the Node.js runtime across the project to version 22. GitHub Actions workflows in .github/workflows/ are updated to use Node.js 22 for CI/CD pipelines. Package versions are bumped to 3.0.0 across three packages: server, sql-parser, and sqlint. The server and sqlint packages update their Node.js engine requirements from >=18.0.0 to >=22.0.0, while sql-parser moves from >=0.8.0 to >=22.0.0. Inter-package dependencies are aligned to use version 3.0.0 of sql-parser and sqlint.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately summarizes the main change: updating Node.js requirement to version 22 across workflows and package.json files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c46c7f6 and b541c52.

📒 Files selected for processing (6)
  • .github/workflows/cd.yml (1 hunks)
  • .github/workflows/publish.yaml (2 hunks)
  • .github/workflows/test.yaml (1 hunks)
  • packages/server/package.json (3 hunks)
  • packages/sql-parser/package.json (2 hunks)
  • packages/sqlint/package.json (3 hunks)
🔇 Additional comments (12)
.github/workflows/cd.yml (1)

43-48: Workflow Node.js version aligned with requirement.

Updating to Node 22 is consistent with the engine requirement changes across packages.

.github/workflows/test.yaml (1)

8-10: Test workflow aligned to Node 22.

Version constraint matches the engine requirement across packages.

.github/workflows/publish.yaml (2)

18-21: Publish workflow: sql-parser job aligned to Node 22.

Version constraint matches engine requirement.


57-60: Publish workflow: server job aligned to Node 22.

Version constraint matches engine requirement.

packages/sql-parser/package.json (2)

5-5: Version bump to 3.0.0 signals breaking change.

Appropriate for the major engine requirement shift.


20-21: Engine requirement jump from ≥0.8.0 to ≥22.0.0 is a notable breaking change.

The shift is dramatic but justified by the 3.0.0 major version bump. Ensure downstream consumers understand this restriction.

packages/sqlint/package.json (3)

3-3: Version bump to 3.0.0 consistent with dependency upgrades.

Signals breaking change aligned with sql-parser upgrade.


24-26: Engine constraint added with ≥22.0.0 requirement.

Aligns with the rest of the monorepo and server's dependency requirement.


38-38: Dependency @deepnote/sql-parser pinned to ^3.0.0.

Correctly tracks the major version bump of sql-parser.

packages/server/package.json (3)

3-3: Version bump to 3.0.0 aligns with dependency updates.

Consistent with major version changes in dependent packages.


23-24: Engine requirement updated to ≥22.0.0.

Consistent with the rest of the monorepo upgrade.


45-46: Inter-package dependencies aligned to ^3.0.0.

Both sql-parser and sqlint dependencies correctly track their major version bumps.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Artmann Artmann merged commit 61e8afe into release Dec 2, 2025
2 checks passed
@Artmann Artmann deleted the chris/bump-node-versions branch December 2, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants