Skip to content

chore(deps): update dependency glob to v10 [security] #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): update dependency glob to v10 [security] #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 82 additions & 87 deletions src/test/vscode-notebook-perf/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/test/vscode-notebook-perf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@types/vscode": "^1.78.0",
"@vscode/test-cli": "^0.0.8",
"@vscode/test-electron": "^2.3.9",
"glob": "^7.1.2",
"glob": "^10.0.0",
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Update caret range to exclude vulnerable patch versions: glob@^10.5.0.

The caret range ^10.0.0 allows versions 10.0.0 through <11.0.0, which includes vulnerable versions 10.3.7–10.9.x (CVE-2025-64756). The security patch was introduced in glob@10.5.0. Per the PR objectives, the remediation is to upgrade to glob@10.5.0 or later.

-    "glob": "^10.0.0",
+    "glob": "^10.5.0",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"glob": "^10.0.0",
"glob": "^10.5.0",
🤖 Prompt for AI Agents 
In src/test/vscode-notebook-perf/package.json around line 35, the dependency
range "glob": "^10.0.0" permits vulnerable 10.x releases; change the version
spec to "glob": "^10.5.0" (or ">=10.5.0 <11.0.0") to ensure the security patch
is included, then regenerate lockfile (npm/yarn install) so package-lock.json or
yarn.lock is updated and run tests to verify nothing breaks.

"mocha": "^10.8.2",
"typescript": "^5.3.3"
},
Expand Down
Loading