Add FAISS DocumentStore integration#2844
Open
GunaPalanivel wants to merge 2 commits intodeepset-ai:mainfrom
Open
Add FAISS DocumentStore integration#2844GunaPalanivel wants to merge 2 commits intodeepset-ai:mainfrom
GunaPalanivel wants to merge 2 commits intodeepset-ai:mainfrom
Conversation
- Remove duplicate _check_condition method (lines 111-148) - Remove unreachable comparison operator checks (lines 348-355) - Reduces codebase by 46 lines of unreachable code - All tests still passing (55 passed, 2 skipped)
GunaPalanivel
requested review from
davidsbatista
and removed request for
a team
github-actions
bot
added
the
type:documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new FAISSDocumentStore integration for Haystack 2.x.
Changes
Core Implementation
FAISSDocumentStorewith full Haystack 2.x protocol supportFeatures
Persistence
Error Handling
FilterErrorfor invalid filter operationsTesting
55 tests passing, 2 skipped
Uses Haystack’s standard DocumentStore test mixins
Covers:
Run:
hatch run test:all # 55 passed, 2 skippedChecklist