docs(llama_cpp): remove explicit warm_up calls#2852
Open
GunaPalanivel wants to merge 1 commit intodeepset-ai:mainfrom
Open
docs(llama_cpp): remove explicit warm_up calls#2852GunaPalanivel wants to merge 1 commit intodeepset-ai:mainfrom
GunaPalanivel wants to merge 1 commit intodeepset-ai:mainfrom
Conversation
Components now warm up automatically on first run, so explicit calls in
examples are redundant.
github-actions
bot
added
integration:llama_cpp
type:documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
warm_upon their first run #2751Llama.cpp components now auto-warm-up on first run, so explicit
warm_up()calls in examples are redundant.Changes
Removed explicit
warm_up()call from docstring examples in:LlamaCppChatGeneratorRemoved explicit
warm_up()call from:examples/llama_cpp_generator_example.pyTesting
hatch run test(skipped locally due to missing build environment; relying on CI validation).