Improve spt update token fallback handling#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks how
spt updateapplies GitHub tokens so a stale ambient token no longer breaks public-repo update checks, while deliberate--tokenusage still fails clearly.Background: a user hit
401 Unauthorized: Bad credentialsrunningspt updateagainst the public repo because a staleGITHUB_TOKEN/SPT_GITHUB_TOKEN(or dotenv value) was eagerly sent. Public release lookup does not require auth.Behavior
--tokenauthenticates from the first request and fails clearly if invalid (no silent ignore even when unauthenticated would have worked).403+Retry-After), not just primary (X-RateLimit-Remaining: 0).Conscious trade-off
For private repos, an ambient token is only exercised on the rate-limit retry; explicit
--tokenremains the supported private-repo path. This matches the stated public-repo scope and is documented in the planning notes.