Skip to content

Sync recent TemplateDotNetTool changes to FileAssert#6

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/sync-recent-changes-from-template
Mar 30, 2026
Merged

Sync recent TemplateDotNetTool changes to FileAssert#6
Malcolmnixon merged 2 commits intomainfrom
copilot/sync-recent-changes-from-template

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

Applies the most recent pull-request changes from the TemplateDotNetTool template repository to keep this repository consistent with template evolution.

Description

Ports the following template PRs:

Template PR #76 — Agent restructure and lint cleanup:

  • Replaced 5 old role-based agents (code-quality, requirements, software-developer, technical-writer, test-developer) with 3 new standards-driven agents (developer, implementation, quality)
  • Updated code-review and repo-consistency agents with streamlined workflow and .agent-logs/-based reporting
  • Created .github/standards/ directory with 6 reusable standards files: csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md
  • Rewrote AGENTS.md around the standards-delegation model; agent report convention moved from AGENT_REPORT_*.md to .agent-logs/[agent]-[subject]-[id].md
  • Updated lint.sh / lint.bat: added --silent / --quiet flags to reduce noise
  • Updated .markdownlint-cli2.yaml: added noBanner and noProgress options, added .agent-logs/ exclusion
  • Updated .cspell.yaml, .gitignore, .yamllint.yaml: added .agent-logs/ to exclusion lists
  • Updated build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

Template PR #75 — Formalize build_notes.md path and artifact handling:

  • Updated release.yaml: removed the "Move build_notes.md to root" step; artifacts/build_notes.md is now used directly as bodyFile in the GitHub Release step

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.FileAssert --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes — agent/configuration files and CI/CD workflow files only.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot The repo-consistency agent essentially said it was crippled with no access. Please try running it again to bring in the recent pull-request changes from the template repository.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 30, 2026

@copilot The repo-consistency agent essentially said it was crippled with no access. Please try running it again to bring in the recent pull-request changes from the template reposit...

Applied the following changes from the most recent template PRs in commit c206dc2:

From PR #76 (Agent restructure + lint cleanup):

  • Replaced 5 old role-based agents (code-quality, requirements, software-developer, technical-writer, test-developer) with 3 new standards-driven agents (developer, implementation, quality)
  • Updated code-review and repo-consistency agents with streamlined workflow and .agent-logs/-based reporting
  • Created .github/standards/ with 6 reusable standards files: csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md
  • Rewrote AGENTS.md around the standards-delegation model
  • Updated lint.sh/lint.bat: added --silent/--quiet flags to reduce noise
  • Updated .markdownlint-cli2.yaml: added noBanner/noProgress, .agent-logs/ exclusion
  • Updated .cspell.yaml, .gitignore, .yamllint.yaml: added .agent-logs/ exclusions
  • Updated build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

From PR #75 (build_notes.md path fix):

  • Updated release.yaml: removed "Move build_notes.md to root" step; use artifacts/build_notes.md directly as bodyFile

Copilot AI changed the title [WIP] Update template repository with recent changes Sync recent TemplateDotNetTool changes to FileAssert Mar 30, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 30, 2026 02:59
Copilot AI review requested due to automatic review settings March 30, 2026 02:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this repository’s CI/linting and AI-agent configuration with the latest TemplateDotNetTool template updates, focusing on agent/standards restructuring and quieter lint output.

Changes:

  • Replaced legacy role-based agents with the new standards-driven agent set and added .github/standards/* guidance docs.
  • Reduced lint noise (npm/pip/cspell) and updated markdown/yaml/cspell ignore lists to exclude .agent-logs/.
  • Updated CI workflows: ReviewMark auto-discovers .reviewmark.yaml, and release notes now use artifacts/build_notes.md directly.

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lint.sh Makes lint dependency installs/spellcheck quieter.
lint.bat Windows equivalent of quieter lint execution.
AGENTS.md Rewritten around standards delegation model and new agent lineup.
.yamllint.yaml Ignores .agent-logs/ for YAML linting.
.markdownlint-cli2.yaml Disables banner/progress and ignores .agent-logs/.
.gitignore Ignores .agent-logs/ directory.
.cspell.yaml Ignores .agent-logs/ for spell checking.
.github/workflows/release.yaml Uses artifacts/build_notes.md directly as GitHub Release body.
.github/workflows/build.yaml Removes explicit --definition .reviewmark.yaml (auto-discovery).
.github/standards/csharp-language.md Adds reusable C# coding standards.
.github/standards/csharp-testing.md Adds reusable C# testing standards.
.github/standards/reqstream-usage.md Adds reusable ReqStream usage standards.
.github/standards/reviewmark-usage.md Adds reusable ReviewMark usage standards.
.github/standards/software-items.md Adds reusable software item categorization standards.
.github/standards/technical-documentation.md Adds reusable technical documentation standards.
.github/agents/code-review.agent.md Streamlines formal review workflow instructions.
.github/agents/repo-consistency.agent.md Updates template-alignment workflow and reporting guidance.
.github/agents/developer.agent.md New general-purpose development agent definition.
.github/agents/implementation.agent.md New orchestrator agent definition (state machine workflow).
.github/agents/quality.agent.md New quality-assurance agent definition.
.github/agents/test-developer.agent.md Removes legacy agent definition (superseded by new model).
.github/agents/technical-writer.agent.md Removes legacy agent definition (superseded by new model).
.github/agents/software-developer.agent.md Removes legacy agent definition (superseded by new model).
.github/agents/requirements.agent.md Removes legacy agent definition (superseded by new model).
.github/agents/code-quality.agent.md Removes legacy agent definition (superseded by new model).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon merged commit 902f422 into main Mar 30, 2026
19 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/sync-recent-changes-from-template branch March 30, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants