Skip to content

Additional agent cleanups and synchronizations.#78

Merged
Malcolmnixon merged 4 commits intomainfrom
more-agent-cleanups
Apr 1, 2026
Merged

Additional agent cleanups and synchronizations.#78
Malcolmnixon merged 4 commits intomainfrom
more-agent-cleanups

Conversation

@Malcolmnixon
Copy link
Copy Markdown
Member

@Malcolmnixon Malcolmnixon commented Apr 1, 2026

Pull Request

Description

Additional agent cleanups and synchronizations, including updating .reviewmark.yaml to add requirements.yaml to the needs-review patterns to align with the guidance in .github/standards/reviewmark-usage.md.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

N/A

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

N/A

Copilot AI review requested due to automatic review settings April 1, 2026 05:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-focused synchronization of agent/standards guidance plus a small expansion of the lint scripts to include .NET formatting verification.

Changes:

  • Add dotnet format --verify-no-changes to both lint.sh and lint.bat.
  • Standardize agent reporting filename placeholders and tighten/normalize agent report template fields.
  • Refresh standards docs (project paths, ReviewMark examples, documentation layout) and adjust cspell wordlist.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
lint.sh Adds .NET formatting verification to the lint suite.
lint.bat Adds .NET formatting verification to the lint suite (Windows).
AGENTS.md Updates project structure examples and agent log filename convention.
.github/standards/technical-documentation.md Updates documentation folder layout example (design + reqstream structure).
.github/standards/reviewmark-usage.md Updates ReviewMark needs-review and example paths to newer project layout placeholders.
.github/standards/design-documentation.md Clarifies subsystem folder naming guidance.
.github/standards/csharp-testing.md Fixes “Anti-patterns” wording consistency.
.github/agents/repo-consistency.agent.md Standardizes agent log filename placeholder and report template fields.
.github/agents/quality.agent.md Standardizes agent log filename placeholder and report template fields.
.github/agents/implementation.agent.md Standardizes agent log filename placeholder and report template fields.
.github/agents/developer.agent.md Standardizes agent log filename placeholder and report template fields.
.github/agents/code-review.agent.md Updates review report filename placeholder and report template fields.
.cspell.yaml Updates allowed technical terms (adds venv, removes some entries).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 1, 2026 05:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@Malcolmnixon Malcolmnixon merged commit 485b1b3 into main Apr 1, 2026
6 checks passed
@Malcolmnixon Malcolmnixon deleted the more-agent-cleanups branch April 1, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants