Skip to content

CRTX-252988 - Qualys VMDR: Handle API rate-limit (HTTP 409) with adaptive retry#44519

Open
dtroushinsky wants to merge 7 commits into
masterfrom
CRTX-252988
Open

CRTX-252988 - Qualys VMDR: Handle API rate-limit (HTTP 409) with adaptive retry#44519
dtroushinsky wants to merge 7 commits into
masterfrom
CRTX-252988

Conversation

@dtroushinsky
Copy link
Copy Markdown
Contributor

@dtroushinsky dtroushinsky commented Jun 3, 2026 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-252988

Description

Reduces Qualys rate-limit (HTTP 409) failures during Test and fetch by reading the X-RateLimit-ToWait-Sec header and retrying once after the requested wait. Also switches the test-module request to GET to match the Qualys API endpoint requirements.

Must have

  • Tests
  • Documentation

@dtroushinsky dtroushinsky requested a review from DanielTal87 June 3, 2026 13:51
@dtroushinsky dtroushinsky added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Jun 3, 2026
@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 3, 2026

@marketplace-ai-reviewer start review

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jun 3, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/qualys/Integrations/Qualysv2
   Qualysv2.py86017180%1630, 1644–1645, 1695–1696, 1698, 1722, 1761, 1764, 1832, 1834, 1836, 1845, 1911–1912, 1917–1918, 2061, 2066, 2177–2179, 2200–2202, 2213, 2309, 2311–2313, 2342–2345, 2428, 2432, 2436, 2438, 2477, 2479–2480, 2482, 2495, 2497–2500, 2502–2503, 2505, 2526–2533, 2546–2548, 2563–2566, 2568–2573, 2575, 2593–2597, 2599–2600, 2602–2604, 2606–2608, 2610–2611, 2613–2616, 2618, 2634–2637, 2639–2642, 2644–2646, 2648–2651, 2654, 2672, 2682, 2713–2714, 2716–2717, 2719, 2733–2734, 2736, 2738, 2754–2755, 2757–2758, 2760, 2775–2780, 2782, 2784, 2793–2794, 2867, 2876, 2896, 2950, 2988, 3358, 3406–3407, 3409–3411, 3421–3423, 3425–3426, 3428, 3448–3449, 3454, 3457–3458, 3461, 3464, 3467, 3469–3471, 3474, 3477–3479, 3488, 3576, 3580, 3600–3601
TOTAL86017180% 

Tests Skipped Failures Errors Time
116 0 💤 0 ❌ 0 🔥 3.643s ⏱️

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 3, 2026

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer

This comment was marked as outdated.

Sign in to view

@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 3, 2026

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 3, 2026

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer

This comment was marked as outdated.

Sign in to view

@content-bot

This comment has been minimized.

Sign in to view
@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 3, 2026

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 3, 2026

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 3, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution to the Qualys integration.

I've left a few notes on your PR, mostly focusing on expanding the new retry wrapper to cover more HTTP methods and aligning the logging and wait times with our standards. There are also a couple of quick formatting and styling tweaks needed in the Release Notes and README.

Thanks for your hard work on this!

@DanielTal87, @marketplace-ai-reviewer, @dtroushinsky please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/qualys/Integrations/Qualysv2/Qualysv2.py Outdated
Comment thread Packs/qualys/Integrations/Qualysv2/Qualysv2.py
Comment thread Packs/qualys/Integrations/Qualysv2/Qualysv2.py Outdated
Comment thread Packs/qualys/Integrations/Qualysv2/README.md Outdated
Comment thread Packs/qualys/ReleaseNotes/3_4_2.md
Comment thread Packs/qualys/ReleaseNotes/3_4_2.md Outdated
Comment thread Packs/qualys/ReleaseNotes/3_4_2.md Outdated
@content-bot

This comment has been minimized.

Sign in to view
@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 4, 2026

@marketplace-ai-reviewer re-review

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 4, 2026

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 4, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔄 Re-reviewing updates...

Important

To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.

Thanks for your contribution to the Qualys pack! The update looks good overall, but there is a quick formatting adjustment needed in the release notes regarding how commands and values are styled. Let me know if you have any questions!

@DanielTal87, @dtroushinsky, @marketplace-ai-reviewer please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/qualys/ReleaseNotes/3_4_2.md Outdated
@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 4, 2026

@marketplace-ai-reviewer re-review

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 4, 2026

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Jun 4, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔄 Re-reviewing updates...

Important

To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.

Thank you for your contribution! Re-reviewed your PR, No new issues found. Great work! 👍
Please check the previous comments to ensure all feedback has been resolved.

@DanielTal87, @marketplace-ai-reviewer, @dtroushinsky please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@content-bot

This comment has been minimized.

Sign in to view
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jun 7, 2026

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jun 7, 2026

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 46503ab43a37287f

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@dtroushinsky dtroushinsky added the ForceMerge Forcing the merge of the PR despite the build status label Jun 7, 2026
@dtroushinsky
Copy link
Copy Markdown
Contributor Author

dtroushinsky commented Jun 7, 2026

ForceMerge justification:
The failures are isolated to the prepare-testing-bucket stage on the mpv2, platform, and xpanse marketplaces. The errors are related to test-bucket preparation / infrastructure setup and are not caused by the content changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments

@DanielTal87 DanielTal87 DanielTal87 approved these changes

Assignees

No one assigned

Labels

docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtroushinsky @content-bot @marketplace-ai-reviewer @DanielTal87