Re-enable get-modified-remote-data command#44530
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
MosheEichler
added
the
release-notes-only
MosheEichler
added
the
ready-for-ai-review
Coverage Report
|
||||||||||||||||||||||||||||||
|
|
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi there! Thanks for contributing this new command to the XSOAR mirroring integration. I've left a few notes to help polish the PR before we can get it merged.
The most important item is that adding a new command requires a minor version bump (2.2.0) rather than a patch. You'll also need to update the README to include command examples, standard phrasing, and snake_case arguments for the new command—running demisto-sdk generate-docs should help automate much of this formatting. Lastly, please remember to add relevant vendor keywords to the pack metadata.
Thanks again for the great work on this!
Additionally, please address the following file-level notes:
Packs/XSOARmirroring/pack_metadata.json: Thekeywordslist is currently empty. Please add the vendor's name (e.g.,CortexorXSOAR) to thekeywordslist.Packs/XSOARmirroring/ReleaseNotes/2_1_3.md: The release notes describe the addition of a new command, which is a feature addition. According to semantic versioning rules, this requires a minor bump (e.g., 2.2.0) rather than a patch bump (2.1.3). Please update the version inpack_metadata.jsonand rename this file to2_2_0.md. You can usedemisto-sdk update-release-notes -i Packs/XSOARmirroring -u minorto automate this. Refer to the Release Notes Documentation.
@MosheEichler please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| *** | ||
| Returns a list of incident IDs that were modified since the last sync. Used to enable incremental mirroring and avoid full blind syncs. | ||
|
|
||
| > **Note:** This command is supported only for Cortex XSOAR version 8.14 and later. |
There was a problem hiding this comment.
Please confirm if this command is also applicable to Cortex XSIAM. If it is, consider updating this note to include Cortex XSIAM (e.g., 'supported only for Cortex XSOAR and Cortex XSIAM version 8.14 and later').
|
|
||
| #### Base Command | ||
|
|
||
| `get-modified-remote-data` |
There was a problem hiding this comment.
The Command example section is missing for this command. According to the Command Examples - Integration Documentation guidelines, every command should have a command example with real CLI syntax.
Please add a #### Command example section (e.g., !get-modified-remote-data lastUpdate="2023-01-01T00:00:00Z") and consider regenerating the README using demisto-sdk generate-docs.
|
|
||
| #### Context Output | ||
|
|
||
| There is no context output for this command. |
There was a problem hiding this comment.
The standard SDK-generated phrasing for commands without context outputs is 'There are no context outputs for this command.' Please update this phrasing.
We recommend using demisto-sdk generate-docs to ensure all standard sections (like Human Readable Output) are included and formatted correctly. See Creating Documentation.
| There is no context output for this command. | |
| There are no context outputs for this command. |
| ### get-modified-remote-data | ||
|
|
||
| *** | ||
| Returns a list of incident IDs that were modified since the last sync. Used to enable incremental mirroring and avoid full blind syncs. |
There was a problem hiding this comment.
The second sentence is a fragment. Consider revising it for better clarity and flow.
| Returns a list of incident IDs that were modified since the last sync. Used to enable incremental mirroring and avoid full blind syncs. | |
| Returns a list of incident IDs that were modified since the last sync. This command is used to enable incremental mirroring and avoid full blind syncs. |
|
|
||
| | **Argument Name** | **Description** | **Required** | | ||
| | --- | --- | --- | | ||
| | lastUpdate | ISO8601 timestamp of the last time the integration was synced. Only incidents modified after this time are returned. | Required | |
There was a problem hiding this comment.
The argument name lastUpdate uses camelCase, whereas XSOAR command arguments typically follow snake_case (e.g., last_update). Please verify if this aligns with the integration's naming conventions. Note that changing this would also require updating the integration YAML file.
|
|
||
| ##### XSOAR Mirroring | ||
|
|
||
| - Added the **get-modified-remote-data** command to support incremental mirroring. |
There was a problem hiding this comment.
Command names should be styled with triple asterisks (bold-italics). Please change **get-modified-remote-data** to ***get-modified-remote-data***. See Entity Styling.
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
4 participants
Status
Related Issues
Description
Added the get-modified-remote-data command
Must have