fixed handling RFC822 email files#44552
Conversation
# Conflicts: # Packs/CommonScripts/ReleaseNotes/1_22_15.md # Packs/CommonScripts/pack_metadata.json
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
merit-maita
added
ready-for-pipeline-running
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for your contribution to the ParseEmailFilesV2 script! The updates look good, but there are a few areas to tighten up regarding error handling, testing, and formatting. Specifically, please add safety checks to prevent AttributeErrors with None values, include a unit test for the new EML misclassification logic, and ensure Docker image tags in the release notes are bolded rather than italicized. Let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/CommonScripts/Scripts/ParseEmailFilesV2/ParseEmailFilesV2.py: Missing unit test for EML misclassification logic.
@kamalq97, @merit-maita please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| #### Scripts | ||
| ##### ParseEmailFilesV2 | ||
| - Fixed an issue where it failed to parse certain valid RFC822 email files due to incorrect file type detection. | ||
| - Updated the Docker image to: *demisto/parse-emails:0.1.48.8921488*. No newline at end of file |
There was a problem hiding this comment.
Values such as Docker image tags must be styled as bold instead of italics.
| demisto.debug(f"{file_type=} seems wrong, changing it to {file_info=}") | ||
| file_type = file_info | ||
|
|
||
| if file_name.lower().endswith(".eml") and ("iso-8859" in file_type.lower() or "mime entity" in file_type.lower()): |
There was a problem hiding this comment.
Add safety checks to prevent AttributeError if file_name or file_type are None.
| file_type = file_info | ||
|
|
||
| if file_name.lower().endswith(".eml") and ("iso-8859" in file_type.lower() or "mime entity" in file_type.lower()): | ||
| demisto.debug(f"Detected EML file misclassified as text ({file_type}), " "forcing RFC822 parsing.") |
There was a problem hiding this comment.
Simplify string concatenation.
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status:
|
3 participants
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Description
Must have