Crtx 265664 migrate script - #45511
Conversation
talzich
added
docs-approved
ready-for-pipeline-running
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
marketplace-ai-reviewer
removed
the
ready-for-ai-review
Coverage Report
|
||||||||||||||||||||||||||||||
|
🤖 Analysis started. Please wait for results... |
| ##### XCloudRelatedAlertsWidget | ||
|
|
||
| - Updated the Docker image to: *demisto/python3:3.12.13.10116658*. | ||
|
|
| core_alert_context = demisto.context().get("Core", {}) | ||
| if not core_alert_context.get("OriginalAlert"): | ||
| original_alert_data = demisto.executeCommand("core-get-cloud-original-alerts", {"alert_ids": alert_context.get("id")}) | ||
| original_alert_data = demisto.executeCommand("getRawAlerts", {"issue_ids": alert_context.get("id")}) |
There was a problem hiding this comment.
This looks good, but you'll need to check server version, I think,
The new command will be available only 8.16.0, right now we still releassing the 8.15
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for contributing to the Cloud Incident Response pack. I have a few quick notes to help get this ready for merging. Please ensure the pack metadata includes the created key and vendor keyword, and update the release notes to follow our versioning phrasing and bold-italic styling guidelines. Lastly, make sure to revert the accidental edit to the historical release note and consider adding error handling to the script's command execution. Thanks again!
Additionally, please address the following file-level notes:
Packs/CloudIncidentResponse/pack_metadata.json: - The mandatory keycreatedis missing from the pack metadata.- The vendor name is missing from the
keywordslist. Packs/CloudIncidentResponse/ReleaseNotes/1_0_36.md: The version bump is a patch (1.0.36), which is allowed only for bug fixes. According to the guidelines, patch release notes must start withFixed an issue. Since this entry starts withUpdated the, it indicates a non-bug-fix change. Please either rephrase the release note to start withFixed an issue(if this is considered a bug fix), or bump the version to minor (1.1.0) and rename this file to1_1_0.md. You can usedemisto-sdk update-release-notes -i Packs/CloudIncidentResponse -u <revision|minor>to regenerate the version and release-notes filename consistently. Refer to the Release Notes Documentation.
@ssokolovich, @Shellyber, @talzich please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
|
|
||
| ##### XCloudAdditionalAlertInformationWidget | ||
|
|
||
| - Updated the script to use the `getRawAlerts` command instead of `core-get-cloud-original-alerts` to retrieve original alert information. |
There was a problem hiding this comment.
Command names must be styled as ***bold-italics*** (e.g., ***command-name***), not with backticks. Please update the styling for getRawAlerts and core-get-cloud-original-alerts. Refer to the Entity Styling guidelines.
| - Updated the script to use the `getRawAlerts` command instead of `core-get-cloud-original-alerts` to retrieve original alert information. | |
| - Updated the script to use the ***getRawAlerts*** command instead of ***core-get-cloud-original-alerts*** to retrieve original alert information. |
| ##### XCloudRelatedAlertsWidget | ||
|
|
||
| - Updated the Docker image to: *demisto/python3:3.12.13.10116658*. | ||
|
|
There was a problem hiding this comment.
Historical release notes should generally not be modified unless fixing a typo in the current PR's context. This appears to be an accidental removal of a trailing dash. Please revert this change.
| core_alert_context = demisto.context().get("Core", {}) | ||
| if not core_alert_context.get("OriginalAlert"): | ||
| original_alert_data = demisto.executeCommand("core-get-cloud-original-alerts", {"alert_ids": alert_context.get("id")}) | ||
| original_alert_data = demisto.executeCommand("getRawAlerts", {"issue_ids": alert_context.get("id")}) |
There was a problem hiding this comment.
- Consider adding error checking for the command result.
- Verify command name, arguments, and output compatibility with
verify_list_type.
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
4 participants
Status
Related Issues
Resolves https://jira-dc.paloaltonetworks.com/browse/CRTX-265664
Description
This PR resolves CRTX-265664. It changes the underlying command for the Cloud Additional Alert script, used in the Cloud Alerts layout. The change in the underlying content is to use the new
getRawAlertPCI command instead of the soon to be deprecated core command.