Fix update_incident_status command failing on empty API response - #45522
Conversation
content-bot
changed the base branch from
master
to
contrib/integrationThreatmon_Ugur-K/fix-update-incident-status-empty-response-1
August 14, 2026 11:49
Contributor
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
Contributor
Contributor
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threatmon_update_incident_statuscommand that was failing withFailed to parse json object from response: b''error./incident/statusAPI endpoint returns200 OKwith an empty body on success. Theset_statusclient method was using the defaultresp_type="json", causing_http_requestto fail when parsing the empty response as JSON.set_statusto useresp_type="response"and updatedchange_incident_statusto checkresponse.okinstead of truthy JSON content.Changes
ThreatMon.py: Addedresp_type="response"toset_status()method, refactoredchange_incident_status()to handle raw responsepack_metadata.json: Version bump1.0.5→1.0.6ReleaseNotes/1_0_6.md: Added release note for the fixTest plan
!threatmon_update_incident_status alarmId="18618355" status="Resolved"in XSOAR and verify it succeeds without JSON parse errorsrelates: link to the issue