refactor(async): improve deadline() validation and performance #6921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage - Add NaN input validation with TypeError - Fix docs: clarify MAX_SAFE_INTEGER boundary behavior - Refactor to avoid unnecessary AbortSignal.any() when not needed - Early return original promise when no timeout and no signal - Add tests for: zero timeout, NaN, custom abort reason, signal priority, MAX_SAFE_INTEGER
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6921 +/- ##
=======================================
Coverage 94.17% 94.18%
=======================================
Files 584 584
Lines 43087 43101 +14
Branches 6875 6880 +5
=======================================
+ Hits 40578 40593 +15
+ Misses 2457 2456 -1
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show ~2.7× faster for the common timeout-only case, ~7× faster when no deadline is needed. The dual-signal path is roughly equivalent.