Skip to content

v3.0.7#596

Merged
devakesu merged 10 commits intomainfrom
3.0.7
Mar 6, 2026
Merged

v3.0.7#596
devakesu merged 10 commits intomainfrom
3.0.7

Conversation

@devakesu
Copy link
Owner

@devakesu devakesu commented Mar 6, 2026

Pull Request

Description

fix(ui): improve attendance actions and login input auto-detection

  • show immediate loading state for disable/enable course confirmations
  • prevent duplicate dialog actions while disable/enable is pending
  • hide “Jump to Today” in calendar empty state when selected date is today
  • auto-switch login method selector while typing email/phone in login field
  • add regression tests for calendar CTA visibility and login method auto-detection

chore(deps): Update dependencies

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which add

Version Bump

  • Version automatically bumped by workflow (same-repo PRs)
  • Version manually bumped using node scripts/bump-version.js (fork PRs)
  • Version already up-to-date (no bump needed)

devakesu added 2 commits March 6, 2026 21:00
- show immediate loading state for disable/enable course confirmations
- prevent duplicate dialog actions while disable/enable is pending
- hide “Jump to Today” in calendar empty state when selected date is today
- auto-switch login method selector while typing email/phone in login field
- add regression tests for calendar CTA visibility and login method auto-detection
Copilot AI review requested due to automatic review settings March 6, 2026 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Version already bumped to v3.0.7

No automatic version bump needed - the PR already includes a version update.

This PR is ready for review! 🚀

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines a few key UI behaviors around attendance actions and login UX, and bumps the app/API version to 3.0.7 with dependency updates.

Changes:

  • Add login identifier auto-detection to switch the login input type (username/email/phone) while typing, plus regression tests.
  • Improve disable/enable course dialogs with immediate pending/loading UI and attempts to block duplicate actions.
  • Hide the “Jump to Today” CTA in the calendar empty state when the selected date is already today, plus regression test.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/components/user/login-form.tsx Adds login-method auto-detection and wires it into the login field onChange.
src/components/user/tests/login-form.test.tsx Adds regression tests for login method auto-detection.
src/components/attendance/course-card.tsx Adds pending/loading UI + disables dialog actions while enable/disable is in progress.
src/components/attendance/attendance-calendar.tsx Hides “Jump to Today” when the selected date is already today.
src/components/attendance/tests/attendance-calendar.test.tsx Adds regression test ensuring the CTA is hidden when redundant.
public/openapi/openapi.yaml Bumps OpenAPI version to 3.0.7.
package.json Bumps app version to 3.0.7.
package-lock.json Updates lockfile for version bump + dependency changes.
.example.env Bumps NEXT_PUBLIC_APP_VERSION to 3.0.7.

@sentry
Copy link

sentry bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 82.81250% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/attendance/course-card.tsx 72.97% 10 Missing ⚠️
src/components/attendance/attendance-calendar.tsx 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/components/attendance/course-card.tsx:672

  • The disable/enable helpers from useDisabledCourses() are a no-op when the semester key can’t be constructed (academicYear/semester are null/undefined). In that case this handler will still close the dialog and show a success toast, which can mislead users into thinking the course was disabled when nothing was persisted. Add a guard that blocks the action (and/or shows an error toast) until both academicYearData and semesterData are available, or until the semester key is non-null.
                event.preventDefault();
                if (!courseCode || disableInFlightRef.current) return;
                disableInFlightRef.current = true;
                const reason = isOtherReason ? customReason.trim() : disableReason;
                setIsDisabling(true);
                try {
                  await disableCourse(courseCode, reason);
                  setShowDisableDialog(false);
                  toast.success(`${courseCode} disabled`, {

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Devanarayanan <fusion@devakesu.com>
Copilot AI review requested due to automatic review settings March 6, 2026 16:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Devanarayanan <fusion@devakesu.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

@devakesu devakesu merged commit fcd8eeb into main Mar 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants