Skip to content

Conversation

@lubojr
Copy link

@lubojr lubojr commented Jan 20, 2026

Minor addition letting users define resources of docserver and browser services in a similar manner as other (raster/vector) are set up.

Docserver shared settings for both containers is intentional, but can be split if needed.

Would be happy for a review! Thanks!

@pantierra
Copy link
Contributor

Many thanks for the PR!

  • Please have a look at the linter, i think there is an nindent that might be different (i guess 12).
  • Can you please also add the new fields to the values.schema.json
  • And if you want to go fancy, some helm-unit tests (not required for this PR to get in)

@lubojr
Copy link
Author

lubojr commented Feb 5, 2026

Thank you for the review! I've tried to address all the points. Let's see when the pipeline is approved (I did not test the helm test itself locally).

@pantierra pantierra force-pushed the feature/resources-browser-docserver branch from 793b149 to 4f3195b Compare February 6, 2026 15:54
@pantierra pantierra force-pushed the main branch 14 times, most recently from e6298c0 to fa222be Compare February 10, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants