feat: add tooltip position appear below#12
Open
kala2 wants to merge 2 commits intodevfolioco:mainfrom
Open
Conversation
prateek3255
reviewed
Oct 1, 2020
Contributor
|
Please update the README as well and don't modify the demo. |
kala2
force-pushed
the
tooltip-bottom
branch
6 times, most recently
from
6822bc8 to
59ceee7
Compare
fix: add type string literal for tooltipPosition Update Readme Revert to previous Readme Update Readme from master
Author
|
@prateek3255 Could you please review the README and accept the PR? Thanks!! |
prateek3255
reviewed
Oct 14, 2020
| > | ||
| <h1 style={{ marginBottom: "50px" }}>Copy email address to clipboard</h1> | ||
| <CopyMailTo email="email@domain.com" /> | ||
| <CopyMailTo email="email@domain.com" tooltipPosition="below" /> |
Contributor
There was a problem hiding this comment.
As I mentioned previously as well, please don't modify the demo.
prateek3255
reviewed
Oct 14, 2020
|
|
||
| const tooltipBaseStyles: React.CSSProperties = { | ||
| bottom: "26px", | ||
| const tooltipBaseStyles = (tooltipPosition: string): React.CSSProperties => ({ |
Contributor
There was a problem hiding this comment.
The type should be ToolTipPosition, right
Contributor
|
@kala2 Any updates here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.