Skip to content

Conversation

@JDBetteridge
Copy link
Contributor

All of the manual changes needed to pass new linting rules

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JDBetteridge JDBetteridge changed the base branch from JDBetteridge/use_ruff to main January 2, 2026 14:38
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 90.16641% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.08%. Comparing base (f020eb1) to head (35f179c).

Files with missing lines Patch % Lines
devito/arch/compiler.py 46.15% 14 Missing ⚠️
tests/test_dimension.py 43.75% 9 Missing ⚠️
devito/passes/iet/langbase.py 40.00% 6 Missing ⚠️
tests/test_data.py 33.33% 6 Missing ⚠️
conftest.py 50.00% 4 Missing ⚠️
tests/test_subdomains.py 55.55% 4 Missing ⚠️
devito/ir/stree/tree.py 50.00% 3 Missing ⚠️
devito/mpi/distributed.py 77.77% 2 Missing ⚠️
devito/passes/iet/languages/openacc.py 77.77% 2 Missing ⚠️
devito/passes/iet/parpragma.py 77.77% 2 Missing ⚠️
... and 12 more

❗ There is a different number of reports uploaded between BASE (f020eb1) and HEAD (35f179c). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (f020eb1) HEAD (35f179c)
18 10
pytest-gpu-nvc-nvidiaX 1 0
pytest-gpu-aomp-amdgpuX 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2813       +/-   ##
===========================================
- Coverage   82.98%   45.08%   -37.90%     
===========================================
  Files         248      248               
  Lines       51012    50985       -27     
  Branches     4491     4474       -17     
===========================================
- Hits        42332    22987    -19345     
- Misses       7909    27038    +19129     
- Partials      771      960      +189     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX ?
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/ruff_manual_changes branch 3 times, most recently from abe5c88 to 6f00c38 Compare January 2, 2026 17:12
@JDBetteridge JDBetteridge force-pushed the JDBetteridge/ruff_manual_changes branch from 6f00c38 to 35f179c Compare January 2, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants