Resolve conf #23
Merged
Resolve conf #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19434
Reported-by: Stanislav Fort (Aisle Research) Closes curl#19438
In the logic called for curl_multi_fdset(). File descriptors larger than FD_SETSIZE size are simply ignored, which of course will make things break but at least it does not trash memory. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19439
We should goto fail as topic is allocated. Follow-up to 92fd791 Closes curl#19417
Reported-by: Stanislav Fort (Aisle Research) Closes curl#19440
They make git branch names using those parentheses, that need to be quoted when used with git command lines. Avoid parentheses for easier to use branch names. Follow-up to f77c574 Closes curl#19441
When a blob option is used and it does not convert, the code would erroneously pass along an uninitialized stack struct. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19444
The memory is allocated with malloc(). This reverts commit 1d01d49. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19445
A variable missed in the previous rename cleanup Follow-up to 928363f Reported-by: Gisle Vanem Closes curl#19446
Data files no longer depend on mixed newline styles. Before this patch the harness still assumed data files to use LF newlines, ensured by `.gitattribute` and distributing sources with LF newlines. To allow using platform native newlines (CRLF on Windows typically), update the test harness to support data files with any newline style on disk. And delete `.gitattributes`. Fix to: - load original data files (from test/data) so that their newline-style doesn't matter on the checked out source repo, meaning it works when its CRLF on Windows, just like any other file. (if a BOM slips in, it's caught by `spacecheck.pl` as binary content.) - do the same in `util.py` used by `smbserver.py` (for test 1451). - also fix `util.py` to use us-ascii encoding for data files, replacing utf-8. Also: - runtests: rework the stray CR checker to allow full CRLF data files, and keep warning for mixed newlines. Follow-up to 904e7ec curl#19347 Closes curl#19398
Fix SC2046: "Quote this to prevent word splitting." Ref: https://www.shellcheck.net/wiki/SC2046 Also: - shellcheck.sh: add `set -eu`. - shellcheck.sh, yamlcheck.sh: always run from repo root. - pass `--` before passing the list of files, where missing. - badwords.pl, cleancmd.pl: rework to accept `git ls-files` arguments. Requires Perl 5.22+ (2015-Jun-01) on Windows. Ref: https://perldoc.perl.org/functions/open - INTERNALS.md: require Perl 5.22 on Windows. - spacecheck.pl: formatting. - GHA/http3-linux: rework command to avoid SC2046. - stop suppressing SC2046 warnings. The yamlcheck.sh issue reported-by: Stanislav Fort (Aisle Research) Ref: 20251109163515_6eb31da3-deb2-4f4d-8327-935904f27da5 Closes curl#19432
To prevent misinterpreting quotes or other special characters. Requires Perl 5.22+ (2015-Jun-01) on Windows. Ref: https://perldoc.perl.org/functions/open Closes curl#19437
``` SC2034: dl appears unused ``` Also to shorten the code. Closes curl#19449
Also: - OS400/makefile.sh: use end-of-options marker in xargs command. - OS400/make-tests.sh: drop warning suppression. Seems to not trigger anymore as of shellcheck 0.11.0 Closes curl#19451
Saving ~30 seconds in jobs affected. Closes curl#19456
- allow 02_28 to run in HTTP/1.1 without H2 support again. Follow-up to 3752de4 curl#19412 - fix to skip 02_28 for all protocols for curl without compression support (either zlib, brotli or ztsd). Closes curl#19458
pytests after: 527 passed, 286 skipped pytests before: 392 passed, 423 skipped runtests after: TESTDONE: 1646 tests out of 1646 reported OK: 100% runtests before: TESTDONE: 1643 tests out of 1643 reported OK: 100% Ref: b81d30a curl#19458 Closes curl#19457
When asking for the last N bytes of a file, and that size was larger than the file size, it would miss the first byte due to a logic error. The fixed range parser is now made a common function in the file now renamed to vssh.c (from curl_path.c) - used by both backends. Unit test 2605 verifies the parser. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19460
Without unit, show up to 99999 "raw" (5 digits). After that, prefer to show the number as less than 1000 per unit and use single decimal fraction. Like '123.4M' (spending 6 characters). This now makes the largest possible size to show 8.0E (exabytes). Probably makes the output easier to read. Fixes curl#19431 Reported-by: Fd929c2CE5fA on github Closes curl#19433
Verify that wolfSSL_BIO_meth_new() actually works and handle situations where it returns NULL. Reported-by: Stanislav Fort (Aisle Research) Closes curl#19459
Continuing when one of these has failed is fragile and error-prone. Closes curl#19513
An error case that previously did not properly return error. Closes curl#19517
Sync outliers with the rest of the code. Also: - return error in some failed init cases, instead of `CURLE_OK`: 1908, 1910, 1913, 2082, 3010 - lib1541: delete unused struct member. Closes curl#19515
Follow-up to 9678ff5 curl#18776 Closes curl#19519
Reported-by: Nick Korepanov Fixes curl#19524 Closes curl#19526
Line 143: "if(duringconnect)" would always equal true. While this is harmless, I believe this minor tweak makes the flow slightly more obvious to the reader and avoids the redundant condition. Pointed out by CodeSonar Closes curl#19523
Save some cpu cycles in debug mode for getinfo. Look up env vars for overwriting variables only when variables are actually requested. Closes curl#19525
Cleanup the vtls pinned key matching somewhat. Add a DEBUGF for pinned key hashes that do not match, so we can see in traces what was going on. Ref curl#19489 Closes curl#19529
Instead of blasting the user with infof() statements. Reported-by: Aleksandr Sergeev Fixes curl#19520 Closes curl#19527
The HTTP/3 tests did send 20 transfers against nghttpx with a backend that failed the uploads with a 400 and an incomplete response body. This causes stream resets. Apache keeps the connection open, but newer nghttpx closes the front connection after "too many" reset. When that bites, it depends on the number of transfers ongoing how the test case fails. This led to flaky outcomes. Reduce the transfers to just a single one and check the result of that one. Parallelism is not important here. refs curl#19489 Closes curl#19530
Also: - extend `dir` rule to exclude C assignments. Closes curl#19532
Also: - GHA/checkdocs: fix CI filters to catch it early. Follow-up to 28dd14a curl#15797 Closes curl#19533
Causing warnings if a matched line has mask patterns. Closes curl#19534
Replacing previous default: MD5. You can use the existing `-s` option to override the default. Also bump version to 1.30. Closes curl#19359
- badwords.pl: add `-a` option to check all lines in source code files. Before this patch indented lines were skipped (to avoid Markdown code fences.) - GHA/checksrc: use `-a` when verifying the source code. - GHA/checksrc: disable `So` and `But` rules for source code. - GHA/checksrc: add docs/examples to the verified sources. - badwords.txt: delete 4 duplicates. - badwords.txt: group and sort contractions. - badwords.txt: allow ` url = `, `DIR`, `<file name`. Closes curl#19536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.