Skip to content

Update Node.js version and remove period for consistency #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jclegg03 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Node.js version and remove period for consistency #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions instruction/deliverable2AutomatedDeploy/deliverable2AutomatedDeploy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ steps:
uses: actions/checkout@v4
```

Then it installs Node.js version 20.
Then it installs Node.js version 22.

```yml
- name: Setup Node
Expand All @@ -210,7 +210,7 @@ We then create our version number, set it in a GitHub Action output variable tha
printf '{"version": "%s" }' "$version" > public/version.json
```

Next it builds the distribution bundle by installing all the dependencies, running Vite to do the bundling, and then copying over our 404 handler file fix that we introduced in the last deliverable.
Next it builds the distribution bundle by installing all the dependencies, running Vite to do the bundling.

```yml
- name: Build
Expand Down Expand Up @@ -286,6 +286,6 @@ Once JWT Pizza is live on your domain, go to the [Canvas assignment](https://byu
| Percent | Item |
| ------- | ------------------------------------------------------------------------------------------- |
| 50% | Successful execution of GitHub Actions to deploy JWT Pizza to GitHub Pages on push |
| 10% | Version updated with each build and visible in app footer. |
| 10% | Version updated with each build and visible in app footer |
| 35% | Completely functional JWT Pizza deployed with GitHub Pages accessible on custom domain name |
| 5% | Pipeline status badge display on your JWT Pizza **README.md** home page |