Support 'gateway' option when creating network#32
Open
Vigilans wants to merge 1 commit intodevplayer0:masterfrom
Open
Support 'gateway' option when creating network#32Vigilans wants to merge 1 commit intodevplayer0:masterfrom
Vigilans wants to merge 1 commit intodevplayer0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using docker to build an intermediate gateway (like raspberry pi), we may expect a following workflow:
However, currently
docker-net-dhcpwill always use DHCP published gateway when creating the container, and when that published IP is the same as container's lease IP, an errorDestination unreachablewill raise, preventing us to modify the gateway later after the container created.Thus, this PR add a new option
gatewaywhen creating the docker network, to forcibly uses a user-provided gateway instead of one provided by DHCP when creating the container.Usage example:
docker create .... -o bridge=br-eth -o gateway=192.168.0.2