Skip to content

Conversation

@antoniobenedetti
Copy link
Contributor

The current version of this plugin is outdated from 12th Aug, 2009. This one is from 10 Nov, 2012 https://github.com/marghoobsuleman/ms-Dropdown/tree/master/js/msdropdown

The current version of this plugin is outdated from 12th Aug, 2009. This one is from 10 Nov, 2012 https://github.com/marghoobsuleman/ms-Dropdown/tree/master/js/msdropdown
@rststeam
Copy link

rststeam commented Jan 7, 2014

Is this tested to work with latest gpanel?

@devryan
Copy link
Owner

devryan commented Jan 7, 2014

I initially tried the latest and had issues with it which is why I didn't immediately update it.

@antoniobenedetti
Copy link
Contributor Author

Um.. the dropdown menus are working, but i guess some additional tweaking will be needed.

@devryan
Copy link
Owner

devryan commented Jan 8, 2014

They work, as in they drop down, but all the images etc ceased to work. Will have to figure out why.

@antoniobenedetti
Copy link
Contributor Author

From the changelog: css .arrow class is changed to .ddArrow (it was too common)
But i guess thats not it, maybe some of the other classes are changed too.

@devryan
Copy link
Owner

devryan commented Jan 8, 2014

hmm. Feel free to figure it out if you want, but I am not in a rush to update this js as I've never heard any complaints about it

@antoniobenedetti
Copy link
Contributor Author

Yes, there is no good reason to rush this but updated scripts tend to work more efficiantly and are more secure (XSS wise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants