Enforce HLC drift bounds on backward clock + harden vector clock parsing#27
Merged
dexcompiler merged 5 commits intomainfrom Feb 7, 2026
Merged
Enforce HLC drift bounds on backward clock + harden vector clock parsing#27dexcompiler merged 5 commits intomainfrom
dexcompiler merged 5 commits intomainfrom
Conversation
Check drift after every NewGuidWithHlc state update Add unit tests for backward-clock drift enforcement Update opus 4.6 deep-dive doc to match current implementation
Treat whitespace-only strings as empty vector clock input Limit entry split to a single ':' to avoid malformed parsing Use Lock in VectorClockCoordinator for consistency
Owner
Author
|
@copilot review |
Contributor
|
@dexcompiler I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you. |
Enforce HLC drift bounds on backward clock + harden vector clock parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens HLC drift enforcement and adds regression coverage, plus small robustness improvements to
VectorClockparsing/coordinator locking.HlcGuidFactory.NewGuidWithHlc( )now checks drift (_logicalTimeMs - physicalTimeMs) after every state update, so large backward-clock jumps are detected immediately whenThrowOnExcessiveDrift=true(Split(':', 2, ...))to avoid malformed cases with extra separators.VectorClockCoordinatorusesLockfor consistency with other coordinators.