Skip to content

Allow regex to match on / when loading the result file #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henrikholm89 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow regex to match on / when loading the result file #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ae86b
Allow regex to match on / when loading the result file
henrikholm89 May 27, 2019
2b8499e
Get rid of warning: character class has '-' without escape
henrikholm89 May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cloudscrape_client/executions/result/file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class File
; # first split
(?'providerId'\d+) # Dexi provider id
; # second split
(?'id'[a-z0-9-]*) # file id
(?'id'[a-z0-9\-\/]*) # file id
\Z # end of line
}x
EXPECTED_FORMAT = "FILE:<CONTENT_TYPE>;<PROVIDER_ID>;<FILE_ID>"
Expand Down
6 changes: 3 additions & 3 deletions spec/cloudscrape_client/executions/result/file_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
RSpec.describe CloudscrapeClient::Executions::Result::File do
let(:instance) { described_class.new(value) }

let(:value) { "FILE:image/png;26071;11fed7f0-a508-4dc8-956a-481535c6f88a" }
let(:value) { "FILE:image/png;26071;testaccount/11fed7f0-a508-4dc8-956a-481535c6f88a" }

describe "#id" do
subject(:id) { instance.id }

it "returns id parsed from value" do
expect(id).to eq("11fed7f0-a508-4dc8-956a-481535c6f88a")
expect(id).to eq("testaccount/11fed7f0-a508-4dc8-956a-481535c6f88a")
end

context "when id is not found" do
Expand Down Expand Up @@ -77,7 +77,7 @@
subject(:file_name) { instance.file_name }

it "returns expected file name" do
expect(file_name).to eq("11fed7f0-a508-4dc8-956a-481535c6f88a-26071.png")
expect(file_name).to eq("testaccount/11fed7f0-a508-4dc8-956a-481535c6f88a-26071.png")
end
end

Expand Down