Skip to content

fix: let test-namespace-darwin use the hermetic cc toolchain#5067

Merged
basvandijk merged 1 commit into
masterfrom
basvandijk/hermetic-cc-toolchain-on-namespace-darwin
May 12, 2025
Merged

fix: let test-namespace-darwin use the hermetic cc toolchain#5067
basvandijk merged 1 commit into
masterfrom
basvandijk/hermetic-cc-toolchain-on-namespace-darwin

Conversation

@basvandijk

@basvandijk basvandijk commented May 12, 2025

Copy link
Copy Markdown
Collaborator

CI sometimes runs into the following error on the workflow: Bazel Test macOS Apple Silicon:

ERROR: /Users/runner/work/ic/ic/rs/nns/handlers/lifeline/impl/BUILD.bazel:35:16: CopyIdlFiles 
rs/nns/handlers/lifeline/impl/actor_idl_path failed: I/O exception during sandboxed execution: 
/private/tmp/zig-cache (No such file or directory)

.github/workflows/test-namespace-darwin.yaml doesn't actually use .github/actions/bazel which creates the /tmp/zig-cache directory. So let's create it.

It's unclear why this failure only happens sometimes and didn't happen on #4848 which re-introduced the hermetic CC toolchain.

This also drops:

          # Until we have a hermetic CC toolchain, tell bazel to use the "real" clang
          # (instead of Apple's, which sometimes breaks on wasm32)
          export CC=/opt/homebrew/opt/llvm/bin/clang

since we now have the hermetic CC toolchain available.

@github-actions github-actions Bot added the fix label May 12, 2025
@basvandijk basvandijk changed the title fix: fix test-namespace-darwin with hermetic cc toolchain fix: let test-namespace-darwin use the hermetic cc toolchain May 12, 2025
Comment thread .github/workflows/test-namespace-darwin.yaml
@basvandijk basvandijk marked this pull request as ready for review May 12, 2025 09:36
@basvandijk basvandijk requested a review from a team as a code owner May 12, 2025 09:36
@github-actions github-actions Bot added the @idx label May 12, 2025
@basvandijk basvandijk requested a review from nmattia May 12, 2025 09:36
@basvandijk basvandijk added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 951a1f0 May 12, 2025
@basvandijk basvandijk deleted the basvandijk/hermetic-cc-toolchain-on-namespace-darwin branch May 12, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants