feat: Wrap components as prep for container upgrade#5604
Merged
Conversation
Bownairo
force-pushed
the
eero/container-env
branch
5 times, most recently
from
12e1cc9 to
b033a1a
Compare
Bownairo
force-pushed
the
eero/container-env
branch
from
b033a1a to
fd0ef9f
Compare
nmattia
reviewed
Jun 20, 2025
nmattia
approved these changes
Jun 20, 2025
andrewbattat
approved these changes
Jun 23, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
One missing piece from #5604.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stripwhen compiling or linking. Updating this binary in [NODE-1606] Upgrade build container to 24.04 #5615 has an effect on outputs that was not seen in the build graph. This adds a dependency on the systemstripbinary to thehermetic_cclinker and compiler.podman exportbehaves differently after [NODE-1606] Upgrade build container to 24.04 #5615. This adds an additional layer of sanitizing so that builds before and after the upgrade are consistent.