fix(asset-canister): fix skill errors, add npm versions and evals#102
Open
fix(asset-canister): fix skill errors, add npm versions and evals#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes factual errors in the asset-canister skill, wraps top-level await in code examples, adds npm versions, and creates the first evaluation suite.
Mentions #97, #95, #96, #100.
Changes
Skill (
asset-canister/SKILL.md):awaitinasync function manageAssets()(no top-level await)importforfs— was mid-block (invalid ES module syntax), moved to top@icp-sdk/canisters >= 3.5.0,@icp-sdk/core >= 5.0.0)sourcereferences withdir(dfx terminology → icp-cli)#1:source→configuration.dir#3: clarifyconfiguration.buildis optional,dirmust have content#7: asset canister Wasm version must be >=0.30.2foric_envcookie supportshouldFetchRootKeyis for Node.js scripts only, browser frontends should userootKeyfromic_envcookiehttps://icp0.io/custom-domains/v1/<domain>/validateandPOST .../v1/<domain>)Evaluations (
evaluations/asset-canister.json): New file with 4 output evals + 12 trigger evals.ic-assets.json5)icp.yaml)shouldFetchRootKeyin Node.js scripts