fix(internet-identity): hardcode II canister ID, add fetch binding#91
Closed
fix(internet-identity): hardcode II canister ID, add fetch binding#91
Conversation
- Replace wrong fallback (be2us-64aaa...) with well-known II canister ID (rdmx6-jaaaa-aaaaa-aaadq-cai) — same on mainnet and local replicas - Add `fetch: window.fetch.bind(window)` to HttpAgent.create() to prevent "Illegal invocation" errors in bundled builds (Vite, webpack) - Add new pitfall documenting the fetch binding requirement
Member
Author
|
@sea-snake mentioned that |
This PR moves the binding of the window inside the agent constructor so consumers don't need to explicitly initialise it dfinity/icp-js-core#1316 |
Member
Author
|
Superseded by #101 which addresses both changes from this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
be2us-64aaa...) with the well-known II canister ID (rdmx6-jaaaa-aaaaa-aaadq-cai) — same on mainnet and local replicas, no dynamic lookup neededfetch: window.fetch.bind(window)toHttpAgent.create()to prevent "Illegal invocation" errors in bundled builds (Vite, webpack)