bot: Update proposals candid bindings#7260
Closed
pr-automation-bot-public[bot] wants to merge 2 commits intomainfrom
Closed
bot: Update proposals candid bindings#7260pr-automation-bot-public[bot] wants to merge 2 commits intomainfrom
pr-automation-bot-public[bot] wants to merge 2 commits intomainfrom
Conversation
2 tasks
Contributor
|
I manually triggered this job targeting #7082 to retrieve the new fields requested in https://dfinity.slack.com/archives/C0175CHJ0P6/p1754674886931749. |
2 tasks
Contributor
|
Moved to #7261 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
# Motivation We have an automatic job for this type of change, but since one field used in the tests has been replaced, we need to manually update the codebase. This PR was spun off from #7260. More context [here](https://dfinity.slack.com/archives/C0175CHJ0P6/p1754674886931749) # Changes * Update the version of `IC_COMMIT_FOR_PROPOSALS` specified in `config.json`. * Updated the `proposals` candid files to the versions in that commit. * Updated the Rust code derived from `.did` files in the proposals payload rendering crate. * Update tests to verify the new field. # Tests - [x] Please check the API updates for any breaking changes that affect our code. - [x] Please check for new proposal types and add tests for them. Breaking changes are: * New mandatory fields * Removing mandatory fields * Renaming fields * Changing the type of a field * Adding new variants --------- Co-authored-by: gix-bot <gix-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.
Changes
IC_COMMIT_FOR_PROPOSALSspecified inconfig.json.proposalscandid files to the versions in that commit..didfiles in the proposals payload rendering crate.Tests
Breaking changes are: