chore(deps): bump Ledger libraries to support Nano Gen5 device#7670
chore(deps): bump Ledger libraries to support Nano Gen5 device#7670
Conversation
yhabib
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates Ledger hardware wallet libraries to add support for the new Ledger Nano Gen5 device by bumping related dependencies to their latest versions.
Key Changes:
- Updated
@ledgerhq/hw-transport-webhidfrom^6.27.8to^6.30.11 - Updated
@ledgerhq/hw-transport-node-hid-noeventsfrom^6.27.8to^6.30.16 - Updated transitive dependencies including
@ledgerhq/devices,@ledgerhq/errors, and@ledgerhq/hw-transport
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/package.json | Bumped two main Ledger transport library versions to support Nano Gen5 device |
| frontend/package-lock.json | Updated lockfile with new versions and integrity hashes for Ledger dependencies and their transitive dependencies |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yhabib
force-pushed
the
yhabib/bump-ledger-deps
branch
from
917a974 to
f442d59
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
LGTM, thx
Speaking of, I wonder if @ledgerhq/hw-transport-node-hid-noevents is really useful. I started a draft #7349 few momths ago to remove it but, I think we never tested it.
I did test it and we had an issue with a peer dep, https://dfinity.enterprise.slack.com/archives/C08DN0K8Q9G/p1758009025184629 |
|
Ah thanks a ton, I had forgotten. Will had this reference to the draft! |
Motivation
Bumps ledger related dependencies to add support to the new Ledger Nano Gen5 device.
Changes
Tests
Todos