Skip to content

chore(proposals): remove proposals crate and related infrastructure#7753

Draft
yhabib wants to merge 3 commits intomainfrom
nns1-4334/crate-removal
Draft

chore(proposals): remove proposals crate and related infrastructure#7753
yhabib wants to merge 3 commits intomainfrom
nns1-4334/crate-removal

Conversation

@yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 27, 2026

Motivation

Follow-up to #7752. The get_proposal_payload backend endpoint is gone, so the proposals crate is now unused. Cleaning up the crate and all the surrounding infrastructure (CI workflows, scripts, declarations).

Changes

  • Removed the rs/proposals/ crate and its workspace entry.
  • Removed workspace dependencies only used by proposals (dfn_core, ic-nervous-system-root, ic-protobuf, registry-canister).
  • Removed scripts/proposals/ (codegen scripts) and declarations/used_by_proposals/ (fetched candid files).
  • Removed .github/workflows/update-proposals.yml and the proposals codegen step from checks.yml.
  • Removed scripts/dfx-nns-proposal-args and its test (CI job was already disabled).
  • Removed IC_COMMIT_FOR_PROPOSALS from config.json and proposals references from Dockerfile, scripts/update_ic_commit, and BOT_APPROVED_FILES.
  • Moved nns_governance.did to declarations/nns_governance/ and updated dfx.json (still needed for local dev scripts).

@yhabib yhabib force-pushed the nns1-4334/crate-removal branch from d9cd082 to e6fe034 Compare February 27, 2026 18:41
@yhabib yhabib changed the title DRAFT: crate removal chore(proposals): remove proposals crate and related infrastructure Feb 27, 2026
@yhabib yhabib marked this pull request as ready for review February 27, 2026 20:25
@yhabib yhabib requested a review from a team as a code owner February 27, 2026 20:25
@yhabib yhabib marked this pull request as draft February 27, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants