Skip to content

Api v2 update global task #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
c8y3 wants to merge 204 commits into
base: develop
Choose a base branch
from
Open

Api v2 update global task #979

c8y3 wants to merge 204 commits into from

Conversation

@c8y3
Copy link
Contributor

@c8y3 c8y3 commented Nov 19, 2025 •
edited
Loading

Implementation of PUT /api/v2/global-tasks/{identifier}.

  • Deprecated POST /global/tasks/update/<int:cur_id>
  • Enforced import constraint to not import app.blueprints.iris_user from app.datamgmt.case
  • Moved some models out of models.py into their own file
  • Separated data from code when initializing ioc types
  • added Ruff rules RET501 and RET505

This PR goes with the documentation in iris-doc-src PR#99

Elise17 added 30 commits October 8, 2025 14:04
@Elise17
Started implementation of POST /api/v2/alerts-filters
9a33abf
@Elise17
Fixed analysis check
b7088fd
@Elise17
Added function _load
103ed2c
@Elise17
Deprecated endpoint POST /filters/add in favor of POST /api/v2/alerts…
82bfec6 
…-filters
@Elise17
Added test create alert when filter data is missing
5b1290e
@Elise17
Added test test_create_alert_filter_should_return_filter_type
ea45b99
@Elise17
Added test_create_alert_filter_should_return_filter_name
4c5ddd6
@Elise17
Added test_create_alert_filter_should_return_in_filter_data_alert_title
0a0f63d
@Elise17
Started implementation of GET /api/v2/alerts-filters/{identifier}
af0bf2b
@Elise17
Fixed check analysis
0c911fe
@Elise17
Fixed importation problem
8559ad7
@Elise17
Fixed static analysis
7440b09
@Elise17
Removed user in test
0690eb0
@Elise17
Added test_get_alert_filter_should_return_filter_name
1129b73
@Elise17
Deprecated endpoint GET /filters/{identifier}
97a89e5
@Elise17
Added test_get_alert_filter_should_return_404
622b46a
@Elise17
Added test_get_alert_filter_should_return_404_when_user_has_not_creat…
9a1fffd 
…ed_alert_filter
@Elise17
Fixed static analysis
e4b4998
@Elise17
Started implementation of PUT /api/v2/alerts-filters/{identifier}
69e38c8
@Elise17
Fixed static analysis
ec809ef
@Elise17
Added test_update_alert_filter_should_return_filter_name
f438d3b
@Elise17
Added test_update_alert_filter_should_return_filter_description
930e94c
@Elise17
Added test_update_alert_filter_should_return_filter_type
120bed5
@Elise17
Added test_update_alert_filter_should_return_filter_data_alert_title
48c0957
@Elise17
Added test_update_alert_filter_should_return_404_when_alert_filter_is…
657d441 
…_not_found
@Elise17
Removed identifietr in test_update_alert_filter_should_return_404_whe…
1008f29 
…n_alert_filter_is_not_found
@Elise17
Deprecated endpoint POST /filters/update/{identifier}
78234ef
@Elise17
Started implmentation of endpoint DELETE /api/v2/alerts-filters/{iden…
eb541cb 
…tifier}
@Elise17
Added test_delete_alert_filter_should_return_404_when_alert_not_found
745739c
@Elise17
test_get_alert_filter_should_return_404_after_delete_alert_filter
74bf4ea
c8y3 added 19 commits November 14, 2025 14:28
@c8y3
Removed an occurence of from app import app
8e847c8
@c8y3
Moved down code into the persistence layer
5547959
@c8y3
One import per line
de4607f
@c8y3
Removed unnecessary print in test
8391039
@c8y3
Removed unused parameter, as indicated by deepsource
30756fc
@c8y3
Fixed some deepsource warnings
13def32
@c8y3
Started implementation of PUT /api/v2/global-tasks/{identifier}
313aab0
@c8y3
Do not import iris_current_user from app.datamgmt.case.case_events_db
833bb6e
@c8y3
Moved methods in persistence layer
c04290c
@c8y3
Factored duplicated code
40b7ecf
@c8y3
Separated code from data
abdd755
@c8y3
Moved EvidenceTypes model in new model file evidences.py
2ba73b2
@c8y3
Moved CaseReceivedFile in evidences.py
f793d9e
@c8y3
Do not import iris_current_user from app.datamgmt.case.case_iocs_db
76c1838
@c8y3
Do not import iris_current_user from app.datamgmt.case.case_notes_db
5648d7b
@c8y3
Do not import iris_current_user from app.datamgmt.case.case_rfiles_db
3a9ae9f
@c8y3
Do not import iris_current_user from app.datamgmt.case
fbd2094
@c8y3
Deprecated POST /global/tasks/update/<int:cur_id>
2c289a8
@c8y3
Added tests for field task_close_date of global tasks
1a92dd7
@c8y3 c8y3 requested a review from whikernel November 19, 2025 13:23
@c8y3 c8y3 added the enhancement New feature or request label Nov 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api_v2_update_global_task

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@c8y3 c8y3 linked an issue Nov 19, 2025 that may be closed by this pull request
API v2 update global task #978
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whikernel whikernel Awaiting requested review from whikernel

Assignees

@whikernel whikernel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API v2 update global task

4 participants

@c8y3 @whikernel @Elise17