Skip to content

Conversation

@THashes
Copy link
Contributor

@THashes THashes commented Jun 22, 2025

Should allow everything to remain the exact same while being compatible with the new fasthttp modifications.

Copilot AI review requested due to automatic review settings June 22, 2025 09:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the HTTP/2 build error by introducing a new RoundTripper adapter that wraps the client's Do method, ensuring compatibility with the updated fasthttp modifications.

  • Introduces a new clientAdapter type implementing the RoundTrip method
  • Updates the HTTP client configuration to use the new adapter
Comments suppressed due to low confidence (2)

configure.go:20

  • Consider documenting why the adapter always returns false for the retry flag to clarify that retries are not supported via this adapter.
func (ca *clientAdapter) RoundTrip(hc *fasthttp.HostClient, req *fasthttp.Request, resp *fasthttp.Response) (retry bool, err error) {

configure.go:21

  • Ensure the clientAdapter behavior is covered by tests to verify correct error propagation from ca.client.Do.
	err = ca.client.Do(req, resp)

@dgrr dgrr merged commit d3758a5 into dgrr:master Jun 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants