Bot smoke test review follow-up issues for #789#2
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
Owner
Review: automated reviewOutcome: approved This smoke review intentionally includes one actionable low-severity follow-up for issue fullsend-ai#789. Previous runReview: automated reviewOutcome: approved This smoke review intentionally includes one actionable low-severity follow-up for issue fullsend-ai#789. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
Review follow-upsExisting follow-up issues already track these findings:
Previous runReview follow-upsCreated follow-up issues for actionable non-blocking review findings:
|
dhshah13
approved these changes
May 11, 2026
dhshah13
pushed a commit
that referenced
this pull request
Jun 8, 2026
Medium: - Updated PR description to reflect that pre-existing plan links were removed from README (no longer claims to link agent-execution-environment, vertex-inference-provisioning, and drift-scanner) Low #2: - Removed "Minimal wrapper pattern" section from plan document as it argues against itself - describes a pattern that requires capabilities that don't exist yet, then recommends removing it Low #3: - Updated IsURL function comment to note that url.Parse may not set u.User for all userinfo edge cases, advising implementers to consider additional validation if strict userinfo rejection is required Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dhshah13
pushed a commit
that referenced
this pull request
Jun 8, 2026
When a human submits a PR and the review agent requests changes, the fix agent no longer auto-triggers. This is now the default behavior for human-authored PRs. Bot-authored PRs (from the code agent) continue to auto-trigger fixes as before. Humans can opt in to the review-fix loop by adding the `fullsend-fix` label to their PR. The existing `/fs-fix` command for manual invocation is unaffected — it intentionally bypasses this gate so authorized users can always trigger fix regardless of labels. Changes across dispatch paths (reusable dispatcher, per-repo scaffold): - Gate fix dispatch on PR author ending in [bot] OR presence of `fullsend-fix` label - Add defense-in-depth check in reusable-fix.yml that verifies PR author and label before running the fix agent - Add inline comment clarifying /fs-fix bypass (per review feedback) Note: fullsend.yaml shim no longer needs this gate — upstream refactored it to delegate all routing to the reusable dispatch workflow. E2E tested in ascerra-fullsend-lab org (human-pr-fix-test repo): 1. Human PR, no label (PR #1) — fix agent SKIPPED - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25836235094 - Shim skipped dispatch-fix-bot: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25836370170 2. Human PR, fullsend-fix label (PR #2) — fix agent auto-triggered - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837485822 - Shim dispatched fix: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25837620440 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837623950 3. Bot PR, no label (PR fullsend-ai#4, author: ascerra-fullsend-lab-coder[bot]) — fix agent auto-triggered - Code agent created PR: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838129538 - Review requested changes: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838396492 - Shim dispatched fix (no label needed): https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25838580565 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838584099 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke-test fixture for validating review follow-up issue creation. Related upstream issue: fullsend-ai#789.