feat: (android) Support pinning on the certificate chain#78
Open
jifang wants to merge 1 commit intodiefferson:masterfrom
Open
feat: (android) Support pinning on the certificate chain#78jifang wants to merge 1 commit intodiefferson:masterfrom
jifang wants to merge 1 commit intodiefferson:masterfrom
Conversation
Added support for pinning on the server's root and intermediate certificates. Previously, Android only supported pinning on the leaf certificate. This change improves operational flexibility by allowing pinning on the certificate chain, reducing downtime when issuing new server certificates.
Owner
|
Hi @jifang, This seems a good improvement, but when we enable the validate root and intermediate certificates we are opening to any certificate from the same provider be valid, which I mentioned on this issue. For example, this root certificate is valid for any certificate generated by Let's encrypt:
You can check it with the sites |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for pinning on the server's root and intermediate certificates. Previously, Android only supported pinning on the leaf certificate. This change improves operational flexibility by allowing pinning on the certificate chain, reducing downtime when issuing new server certificates.
#54