Skip to content

Fix convert $in operators with single value to array #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
talesdsp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix convert $in operators with single value to array #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/querymen-param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export default class QuerymenParam extends Param {
} else if (_.isRegExp(value)) {
return operator === '$ne' ? {[path]: {$not: value}} : {[path]: value}
} else {
if (_.includes(['$in', '$nin'], operator) && !_.isArray(value)) {
return {[path]: {[operator]: [value]}}
}
return {[path]: {[operator]: value}}
}
}
Expand Down
2 changes: 2 additions & 0 deletions test/querymen-param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ test('QuerymenParam parse', (t) => {
t.same(parse(123, {operator: '$gt'}), {test: {$gt: 123}}, 'should parse $gt')
t.same(parse(123, {operator: '$gte'}), {test: {$gte: 123}}, 'should parse $gte')
t.same(parse(123, {operator: '$lt'}), {test: {$lt: 123}}, 'should parse $lt')
t.same(parse(123, {operator: '$in'}), {test: {$in: [123]}}, 'should parse $in value to array')
t.same(parse(123, {operator: '$nin'}), {test: {$nin: [123]}}, 'should parse $nin value to array')
t.same(parse(123, {operator: '$lte'}), {test: {$lte: 123}}, 'should parse $lte')
t.same(parse(/test/i, {operator: '$ne'}), {test: {$not: /test/i}}, 'should parse $not')
t.same(parse(123, {parse: (value, path, operator) => ({[path]: operator})}), {test: '$eq'}, 'should parse option')
Expand Down