Skip to content

fix: disable firefox cache to test a potential root cause for the bui… #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diegov wants to merge 1 commit into from
Closed

fix: disable firefox cache to test a potential root cause for the bui… #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,19 @@ jobs:
key: ${{ runner.os }}-pip2-${{ hashFiles('integration_tests/requirements.txt') }}
restore-keys: |
${{ runner.os }}-pip2-
- name: Cache firefox versions
uses: actions/cache@v4
# TODO: restoring the cache still makes sense since the latest version might
# match one we test in the CI build, but we should ensure there is no full
# key match so that the existing cache is not overwritten. We could include
# the current timestamp in the key.
if: github.event_name != 'schedule'
with:
path: |
${{ env.XDG_CACHE_HOME }}/extension_testing
key: ${{ runner.os }}-ff2-${{ hashFiles('integration_tests/firefox_versions', 'integration_tests/firefox.py') }}
restore-keys: |
${{ runner.os }}-ff2-
# - name: Cache firefox versions
# uses: actions/cache@v4
# # TODO: restoring the cache still makes sense since the latest version might
# # match one we test in the CI build, but we should ensure there is no full
# # key match so that the existing cache is not overwritten. We could include
# # the current timestamp in the key.
# if: github.event_name != 'schedule'
# with:
# path: |
# ${{ env.XDG_CACHE_HOME }}/extension_testing
# key: ${{ runner.os }}-ff2-${{ hashFiles('integration_tests/firefox_versions', 'integration_tests/firefox.py') }}
# restore-keys: |
# ${{ runner.os }}-ff2-
- name: Run integration tests
if: github.event_name != 'schedule'
# CI run, test against the versions we specify in the firefox_versions file
Expand Down