Skip to content

Replace ONCE_INIT with Once::new() #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weiznich merged 1 commit into from
Aug 6, 2019
Merged

Replace ONCE_INIT with Once::new() #2108

weiznich merged 1 commit into from
Aug 6, 2019

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jul 7, 2019

ONCE_INIT will be deprecated in the future release (see rust-lang/rust#61757).
For the future, we can now use Once::new().

@JohnTitor JohnTitor requested a review from a team July 7, 2019 08:27
@killercup killercup mentioned this pull request Jul 12, 2019
Closed
@KeenS KeenS mentioned this pull request Jul 25, 2019
Closed
@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 25, 2019

If we don't allow deprecated items in #2117, I think we should merge this to make CI green. What about? @sgrif

@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 25, 2019

Uh, I cannot re-run pipelines but it should be green.

@sgrif
Copy link
Member

sgrif commented Jul 25, 2019

Rerun isn't doing anything for me either. Can you close/re-open?

@JohnTitor JohnTitor closed this Jul 25, 2019
@JohnTitor JohnTitor reopened this Jul 25, 2019
@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 26, 2019 •
edited
Loading

Hmm, the inner_join test is failed in macOS_mysql. This also appears in #2126.

@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 28, 2019

It seems the reason is MySQL version. 8.0.16 passes but 8.0.17 fails.

@weiznich weiznich mentioned this pull request Aug 1, 2019
Closed
2 tasks
@JohnTitor JohnTitor mentioned this pull request Aug 1, 2019
Merged
@weiznich
Copy link
Member

weiznich commented Aug 6, 2019

Could you rebase this PR on top of #2131 to fix the CI?

@weiznich weiznich merged commit 74944c0 into diesel-rs:master Aug 6, 2019
@JohnTitor JohnTitor deleted the use-once-new branch August 6, 2019 19:56
@weiznich weiznich mentioned this pull request Sep 30, 2019
Closed
@weiznich weiznich mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnTitor @sgrif @weiznich