feat(desktop): skip built-in MCP servers when OPENWORK_DISABLE_BUILTIN_MCP=1#1826
Open
yashranaway wants to merge 1 commit into
Open
feat(desktop): skip built-in MCP servers when OPENWORK_DISABLE_BUILTIN_MCP=1#1826yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@yashranaway is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
yashranaway
force-pushed
the
feat/disable-builtin-mcp-servers
branch
from
5a0d8e2 to
583b434
Compare
|
Hey, my bosses are interested in testing Openwork - can somebody review this so I can give them a version working on corporate computers? Thanks! |
yashranaway
force-pushed
the
feat/disable-builtin-mcp-servers
branch
from
583b434 to
06a147a
Compare
Dhanus3133
reviewed
Jun 17, 2026
Dhanus3133
left a comment
Dhanus3133
left a comment
There was a problem hiding this comment.
Some are pending:
- browser bridge in preload.mjs
- opencode-chrome-devtools plugin in runtime config
- (couple more comments below)
Comment on lines
303
to
305
| const remoteDebugPort = Number.isFinite(explicitCdpPort) && explicitCdpPort > 0 | ||
| ? explicitCdpPort | ||
| : await findFreeCdpPort([9223, 9224, 9225, 9226, 9227]); |
Comment on lines
390
to
392
| const browserPanel = createBrowserPanel({ | ||
| remoteDebugPort, | ||
| getWindow: () => mainWindow, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1806
Summary
OPENWORK_DISABLE_BUILTIN_MCPread via the existingenvFlagEnabledhelper so corporate installs that prohibit local hosting can opt out without changing source.ensureBrowserMcpServers()before it binds the built-in browser MCP and external Chrome MCP ports.seedBrowserMcpConfig()already early-returns on a null result, so workspace-create writes noopenwork-browser/chromeentries either.startUiControlServer()at the boot site so the UI-control bridge is not spawned and the matchingopenwork-ui-control.jsondiscovery file is never written.[browser-mcp] Skipped (OPENWORK_DISABLE_BUILTIN_MCP=1)/[ui-control] Skipped ...) so the reporter can verify in logs as the issue suggests.Verification
node --check apps/desktop/electron/main.mjspasses.grep envFlagEnabled apps/desktop/electron/main.mjsconfirms the new flag uses the same truthy-string parser (1/true/yes/on) asOPENWORK_FORCE_SIGNIN.OPENWORK_DISABLE_BUILTIN_MCP=1 openwork, check Electron logs for bothSkippedlines and confirmnetstat -an | grep LISTEN | grep 6488no longer shows the built-in browser MCP ports.Notes
apps/app/src/react-app/) and is a separate surface; this PR is the main-process gate the reporter asked for. Happy to follow up with the button visibility tied to a runtime flag exposed via the desktop bridge if maintainers want.