docs(docker): clean up on-prem runbooks#1896
Closed
pascalandr wants to merge 15 commits into
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@pascalandr is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 12 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Copy workspace manifests before source files so Docker can reuse the pnpm install layer across source-only changes.
There was a problem hiding this comment.
2 issues found across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packaging/docker/Dockerfile">
<violation number="1" location="packaging/docker/Dockerfile:17">
P2: Hardcoded Bun x64 artifact breaks non-x64 Docker builds</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Update static Den compose and runbook wiring so smoke validation covers health, workspace, and env-key routes while keeping internal services off host ports and avoiding persistence of env-supplied worker tokens.
Strengthen real LAN static worker quickstart with the required DEN_STATIC_WORKER_TOKEN_MAP_JSON mapping.
Replace wildcard worker CORS defaults with local-safe origins and require an encoded static Den DATABASE_URL to support special-character MySQL passwords.
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packaging/docker/docker-compose.den-static.yml">
<violation number="1" location="packaging/docker/docker-compose.den-static.yml:53">
P2: Inconsistent DB URL strategy between `den` and `worker-proxy` services — percent-encoding fix only applied to `den`</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| OPENWORK_DEV_MODE: ${OPENWORK_DEV_MODE:-0} | ||
| # Provide a complete URL so passwords with URL-special characters can be percent-encoded. | ||
| # Example: mysql://root:p%40ss%3Aword@mysql:3306/openwork_den | ||
| DATABASE_URL: ${DEN_DATABASE_URL:?DEN_DATABASE_URL is required; percent-encode URL-special password characters} |
There was a problem hiding this comment.
P2: Inconsistent DB URL strategy between den and worker-proxy services — percent-encoding fix only applied to den
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packaging/docker/docker-compose.den-static.yml, line 53:
<comment>Inconsistent DB URL strategy between `den` and `worker-proxy` services — percent-encoding fix only applied to `den`</comment>
<file context>
@@ -48,7 +48,9 @@ services:
- DATABASE_URL: mysql://root:${DEN_MYSQL_ROOT_PASSWORD}@mysql:3306/openwork_den
+ # Provide a complete URL so passwords with URL-special characters can be percent-encoded.
+ # Example: mysql://root:p%40ss%3Aword@mysql:3306/openwork_den
+ DATABASE_URL: ${DEN_DATABASE_URL:?DEN_DATABASE_URL is required; percent-encode URL-special password characters}
BETTER_AUTH_SECRET: ${DEN_BETTER_AUTH_SECRET:?DEN_BETTER_AUTH_SECRET is required}
DEN_DB_ENCRYPTION_KEY: ${DEN_DB_ENCRYPTION_KEY:?DEN_DB_ENCRYPTION_KEY is required}
</file context>
Contributor
Author
|
Superseded by the clean consolidated static/on-prem workers PR #2173. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolates Docker/on-prem runbook cleanup: Docker ignore/build/compose updates, static Den on-prem runbook/README corrections, and portable Den demo seed tooling for disposable E2E setups.
Verification
docker compose -f packaging/docker/docker-compose.yml config— passed.docker compose -f packaging/docker/docker-compose.den-dev.yml config— passed.pnpm --filter @openwork-ee/den-api exec node --check scripts/seed-demo-org-runner.mjs— passed.pnpm --filter @openwork-ee/den-api exec node --import tsx -e "console.log('tsx import ok')"— passed.pnpm --filter @openwork-ee/den-api build— passed.git diff --name-status upstream/dev...pr/docker-onprem-runbookreviewed; notasks/**,docs/scrs/**, codemaps, or generated app-version included.Known risks
Linked issues