feat(den): scheduled jobs#2049
Open
benjaminshafii wants to merge 3 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="ee/apps/den-api/src/routes/workers/core.ts">
<violation number="1" location="ee/apps/den-api/src/routes/workers/core.ts:190">
P2: Switching to organization-context middleware changed create-worker error semantics (now 404/403 from middleware), leaving an unreachable 400 `organization_unavailable` path and inaccurate API response contract.</violation>
</file>
<file name="ee/apps/den-api/src/workers/daytona-provider-seed.ts">
<violation number="1" location="ee/apps/den-api/src/workers/daytona-provider-seed.ts:85">
P1: Silent parse failure can clobber existing `opencode.jsonc` settings by overwriting with only seeded provider data.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| 'fs.mkdirSync(path.dirname(target), { recursive: true })', | ||
| 'let existing = {}', | ||
| 'if (fs.existsSync(target)) {', | ||
| ' try { existing = JSON.parse(fs.readFileSync(target, "utf8")) } catch {}', |
There was a problem hiding this comment.
P1: Silent parse failure can clobber existing opencode.jsonc settings by overwriting with only seeded provider data.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At ee/apps/den-api/src/workers/daytona-provider-seed.ts, line 85:
<comment>Silent parse failure can clobber existing `opencode.jsonc` settings by overwriting with only seeded provider data.</comment>
<file context>
@@ -0,0 +1,95 @@
+ 'fs.mkdirSync(path.dirname(target), { recursive: true })',
+ 'let existing = {}',
+ 'if (fs.existsSync(target)) {',
+ ' try { existing = JSON.parse(fs.readFileSync(target, "utf8")) } catch {}',
+ '}',
+ 'const existingProvider = existing.provider && typeof existing.provider === "object" && !Array.isArray(existing.provider) ? existing.provider : {}',
</file context>
| }), | ||
| requireUserMiddleware, | ||
| resolveUserOrganizationsMiddleware, | ||
| resolveOrganizationContextMiddleware, |
There was a problem hiding this comment.
P2: Switching to organization-context middleware changed create-worker error semantics (now 404/403 from middleware), leaving an unreachable 400 organization_unavailable path and inaccurate API response contract.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At ee/apps/den-api/src/routes/workers/core.ts, line 190:
<comment>Switching to organization-context middleware changed create-worker error semantics (now 404/403 from middleware), leaving an unreachable 400 `organization_unavailable` path and inaccurate API response contract.</comment>
<file context>
@@ -186,11 +187,12 @@ export function registerWorkerCoreRoutes<T extends { Variables: WorkerRouteVaria
}),
requireUserMiddleware,
- resolveUserOrganizationsMiddleware,
+ resolveOrganizationContextMiddleware,
jsonValidator(createWorkerSchema),
async (c) => {
</file context>
benjaminshafii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloud MCP background job flow
Testing
Notes