feat(app): replace dispatch event with typed event bus#2065
Open
JeanMeijer wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 34 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/lib/event-bus.ts">
<violation number="1" location="apps/app/src/lib/event-bus.ts:28">
P2: `emit` makes payload optional for all events, so required event details are no longer enforced by TypeScript.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| emit<TType extends keyof TEvents & string>( | ||
| type: TType, | ||
| detail?: TEvents[TType], |
There was a problem hiding this comment.
P2: emit makes payload optional for all events, so required event details are no longer enforced by TypeScript.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/lib/event-bus.ts, line 28:
<comment>`emit` makes payload optional for all events, so required event details are no longer enforced by TypeScript.</comment>
<file context>
@@ -0,0 +1,81 @@
+
+ emit<TType extends keyof TEvents & string>(
+ type: TType,
+ detail?: TEvents[TType],
+ options?: Omit<CustomEventInit<TEvents[TType]>, "detail">,
+ ) {
</file context>
Member
|
Daytona E2E validation for PR #2065: FAIL Tested ref/commit: Proof:
Assertions/results:
Additional log evidence:
Caveats:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.dispatchEvent/addEventListenercalls with a typed internal event bus so app-wide events are centralized and type-safe.eventsAPI.