fix(server): skip file initialization for remote workspaces#2070
Open
AllenSHH wants to merge 1 commit into
Open
fix(server): skip file initialization for remote workspaces#2070AllenSHH wants to merge 1 commit into
AllenSHH wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Someone is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
b4fee2c to
a5825f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureWorkspaceFiles) for remote workspaces (workspaceType === "remote") in both the CLI (cli.ts) and embedded server (embedded.ts) startup paths.opencodeCwdorOPENWORK_MANAGED_OPENCODE_CWD) is explicitly provided, instead of incorrectly blocking on the absence of a local workspace..find()when resolving the default local path fallback.Why
ENOENTdirectory creation errors and causes the server/client startup to crash.opencodeCwd/OPENWORK_MANAGED_OPENCODE_CWD) were explicitly configured for remote-only environments.Issue
Scope
apps/server/src/cli.ts: Filter out remote workspaces during startup initialization, resolve the CWD prior to gating, and select the first local workspace using.find().apps/server/src/embedded.ts: Same filtering, lookup, and conditional CWD gating improvements.Out of scope
workspace-init.ts).Testing
Ran
pnpm --filter openwork-server typecheckbun test src/workspace-init.test.tsResult
CI status
Manual verification
OPENWORK_MANAGED_OPENCODE_CWDenvironment variable.Evidence
N/A (docs-only): N/ARisk
Rollback
apps/server/src/cli.tsandapps/server/src/embedded.ts.