fix(DOSTM 7438): Issue #26 - Forced use of ANDROID_HOME breaks on github runners with it installed by default as you cannot remove the env value#38
Closed
vishalshanbhag-digicert wants to merge 13 commits intomasterfrom
Conversation
…age ssm-client-tools-installer for the fix DOSTM-7214 package-lock.json
…age ssm-client-tools-installer for the fix DOSTM-7214
…s of the dependency
… string escaping or encoding
…ecurity compliance / functionality for newer SDK based builds #24 - Code Changes for the fix
…ws SDK breaks security compliance / functionality for newer SDK based builds #24
…ub runners with it installed by default as you cannot remove the env value
vishalshanbhag-digicert
requested review from
Siddharth-Srinivas,
anshuman-mor and
partharoy-digicert
src/index.ts
Outdated
| "jarsigner", | ||
| ] | ||
| : ["smctl", "ssm-scd", "nuget", "mage", "apksigner"]; | ||
| const isWinPlatform = (osPlat == con.OS_PLATFORM_WIN) ? true : false; |
Collaborator
There was a problem hiding this comment.
You can just write,
const isWinPlatform = (osPlat === con.OS_PLATFORM_WIN);
src/sdk-version-utils.ts
Outdated
| } | ||
|
|
||
| public getAllSdkVersions(dirPath: any, sdkVersions: any = []): any { | ||
| fs.readdirSync(dirPath, {withFileTypes: true}).forEach(file => { |
Collaborator
There was a problem hiding this comment.
as you just need name, you can destructure only that in args,
forEach(({ name }) => {
if(this.isVersionDirectory(name)){
sdkVersions.push(name)
}
})
DOSTM-7438: Review comment fix patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.