Skip to content

DOSTM-7438: Review comment fix patch #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishalshanbhag-digicert merged 2 commits into from
May 26, 2025
Merged

DOSTM-7438: Review comment fix patch #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35cd5b7
fix(DOSTM_7438): Review comment fix
vishalshanbhag-digicert May 26, 2025
ae54e8a
Update index.js for fixing scan failure
vishalshanbhag-digicert May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36525,7 +36525,7 @@ function buildProxyBypassRegexFromEnv(bypass) {
}
catch (err) {
if (err instanceof SyntaxError && (bypass || "").startsWith("*")) {
let wildcardEscaped = bypass.replace('*', '(.*)');
let wildcardEscaped = bypass.replace(/\*/g, '(.*)');
return new RegExp(wildcardEscaped, 'i');
}
throw err;
Expand Down Expand Up @@ -37313,7 +37313,7 @@ const con = __importStar(__nccwpck_require__(9042));
const sdk_version_utils_js_1 = __nccwpck_require__(7796);
const utils = new sdk_version_utils_js_1.SdkVersionUtils();
const osPlat = os_1.default.platform();
const isWinPlatform = (osPlat == con.OS_PLATFORM_WIN) ? true : false;
const isWinPlatform = (osPlat === con.OS_PLATFORM_WIN);
const signtools = isWinPlatform ? con.WIN_OS_TOOL_LIST : con.OTHER_OS_TOOL_LIST;
const toolInstaller = async (toolName, toolPath = "") => {
let cacheDir;
Expand Down Expand Up @@ -37451,9 +37451,9 @@ class SdkVersionUtils {
return numArr;
}
getAllSdkVersions(dirPath, sdkVersions = []) {
fs_1.default.readdirSync(dirPath, { withFileTypes: true }).forEach(file => {
if (this.isVersionDirectory(file.name)) {
sdkVersions.push(file.name);
fs_1.default.readdirSync(dirPath, { withFileTypes: true }).forEach(({ name }) => {
if (this.isVersionDirectory(name)) {
sdkVersions.push(name);
}
});
return sdkVersions;
Expand Down Expand Up @@ -37698,4 +37698,4 @@ module.exports = JSON.parse('{"name":"dotenv","version":"16.0.3","description":"
/******/ module.exports = __webpack_exports__;
/******/
/******/ })()
;
;
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { SdkVersionUtils } from "./sdk-version-utils.js";

const utils = new SdkVersionUtils();
const osPlat: string = os.platform();
const isWinPlatform = (osPlat == con.OS_PLATFORM_WIN) ? true : false;
const isWinPlatform = (osPlat === con.OS_PLATFORM_WIN);
const signtools = isWinPlatform ? con.WIN_OS_TOOL_LIST : con.OTHER_OS_TOOL_LIST;
const toolInstaller = async (toolName: string, toolPath: string = "") => {
let cacheDir;
Expand Down
6 changes: 3 additions & 3 deletions src/sdk-version-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ export class SdkVersionUtils {
}

public getAllSdkVersions(dirPath: any, sdkVersions: any = []): any {
fs.readdirSync(dirPath, {withFileTypes: true}).forEach(file => {
if(this.isVersionDirectory(file.name)){
sdkVersions.push(file.name)
fs.readdirSync(dirPath, {withFileTypes: true}).forEach(({ name }) => {
if(this.isVersionDirectory(name)){
sdkVersions.push(name)
}
});
return sdkVersions;
Expand Down
Loading