Open
Conversation
…ove vulnerabilities.
…dating package-lock.json
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Action’s tool installation flow—especially on Windows—by adjusting how MSI-installed tools are handled, bumping the @digicert/ssm-client-tools-installer dependency, and extending the bundled build output with updated dependency code and improved diagnostics.
Changes:
- Skip
@actions/tool-cachedirectory caching for MSI-installed Windows tools and add the installation directory directly toPATH. - Bump
@digicert/ssm-client-tools-installerfrom^1.6.1to^1.6.2(with corresponding lockfile updates). - Add a new localization string (
LIB_UndefinedNodeVersion) and update the bundledbuild/index.jsto include new installer logic and dependency updates.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Adjusts Windows MSI tool handling (skip caching, PATH updates) and improves Windows zip extraction behavior for Mage. |
| package.json | Bumps @digicert/ssm-client-tools-installer version. |
| package-lock.json | Updates resolved dependency tree for the bumped installer package (and transitive deps). |
| build/lib.json | Adds LIB_UndefinedNodeVersion localization string used by bundled code. |
| build/index.js | Updates the committed ncc bundle with new Windows installer path/locking logic and updated transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to Windows tool installation handling, updates a dependency version, and adds a new error message. The most important changes are grouped below by theme.
Windows tool installation improvements:
toolInstallerinsrc/index.tsto skip caching for MSI-installed tools on Windows adding the install path directly toPATHto avoid archive extraction errors. [1] [2]Dependency update:
@digicert/ssm-client-tools-installerversion from1.6.1to1.6.2inpackage.jsonfor improved compatibility and bug fixes.Error messaging:
LIB_UndefinedNodeVersiontobuild/lib.jsonfor clearer diagnostics when Node version is undefined.