Ensure only NOOP hostname verifier is used for TLS#366
Merged
runeflobakk merged 2 commits intomainfrom Jan 8, 2026
Merged
Conversation
Because of Signering API using non-standard certificates for establishing TLS connection, i.e. enterprise certificates (virksomhetssertifikat). Apache Http Client changed behavior in v5.6, where it is not enough to configure your own HostnameVerifier. To avoid the verification which is built-in the JDK SSL stack, one must explicitly configure this policy to HostnameVerificationPolicy.CLIENT. https://lists.apache.org/thread/xycs1swxpdc4g3255ms0p1kshbl3ky29 (see "Compatibility notes") apache/httpcomponents-client@d89fdfe
runeflobakk
force-pushed
the
only-noop-hostname-verifier
branch
from
1f0566b to
de9f01f
Compare
martin-jackson
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of Signering API using non-standard server certificate for establishing TLS connection, i.e. enterprise certificates (virksomhetssertifikat).
Apache Http Client changed behavior in v5.6 (see "Compatibility notes" in announcement), where it is not enough to configure your own
HostnameVerifier. To avoid the verification which is built-in into the JDK SSL stack, one must explicitly configure this policy to HostnameVerificationPolicy.CLIENT.apache/httpcomponents-client@d89fdfe
This is a backward compatible change, and signature-api-client-java can still be used with previous minor-versions of Apache Http client.