esp8266_pinToGpio not needed for tone()#80
Open
pfeerick wants to merge 1 commit intodigistump:masterfrom
Open
Conversation
The '_pin = esp8266_pinToGpio[_pin];' pin remapping is not needed in the tone library - this actually broke the tone support, and only worked with P3 as it remaps to GPIO3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The '_pin = esp8266_pinToGpio[_pin];' pin remapping is not needed in the tone library - this actually broke tone support, and only worked with P3 as it remaps to GPIO3. Fixes second issue mentioned in #75.
To test, simply run the toneMelody example provided with the Arduino IDE under Examples -> 02. Digital, and change the pin used in lines 38 and 45 to your desired pin. The sketch default is 8, which will do as a test also.