Import local planning authority geometry into pipeline for boundary check #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loads relevant geometry in harmonise
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 79.54% 79.74% +0.20%
==========================================
Files 67 67
Lines 3588 3619 +31
==========================================
+ Hits 2854 2886 +32
+ Misses 734 733 -1
☔ View full report in Codecov by Sentry. |
CarlosCoelhoSL
changed the title
Instead of using data from ONS
CarlosCoelhoSL
changed the title
CarlosCoelhoSL
changed the title
CarlosCoelhoSL
commented
Nov 6, 2023
digital_land/commands.py
Outdated
Comment on lines
143
to
144
| lpa_geometry_path = "var/cache/local-authority.csv" | ||
| local_authority_path = "var/cache/local-authority.csv" |
Contributor
Author
There was a problem hiding this comment.
I've hardcoded these for now, it should be pretty easy to add these as inputs to the pipeline run command, but I'm not sure where that run command is actually triggered
GeorgeGoodall
previously approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to process and load LPA geometry data into the harmonise phase, so it can be used for a custom boundary check in the normalise process. This geometry data will be download during the make init process, using changes found in this PR.
Checking whether an entity lies within its Local Planning Authority boundary only occurs for the brownfield land dataset