Provision quality dataset #404
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only run duplicate reference check when needed
* initial commit * adds tests * adds acceptance test * updated mask fixes tests fixes output path * updates diff calculation for new entities * adds function comments * restructures get user response * test * test
…-land/digital-land-python into provision-quality-dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR introduces a new
generate_provision_quality()function that uses an existing Jupyter notebook logic for generating the provision quality dataset.Updated the code to use the new Digital Land API to fetch the performance SQLite database locally
Querying is now done on the locally downloaded DB rather than downloading performance db from datasette
Being invoked using build-performance.sh from collection-task
Output is saved as a Parquet file which is then uploaded to s3 using airflow-dags
Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Yes